Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more changes to AuditD #310

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

tdekoning93
Copy link
Contributor

Hey!

I'm basically copying the PR of @DeWaRs1206.
#307

Seems he abandoned ship. I really need this though, since we want to change same auditd parameters that currently can't be set. I've changed the attributes mentioned in the comments on that PR to what they should be.

@tdekoning93 tdekoning93 force-pushed the feature/allow_more_changes_auditd branch from cb92aee to e871379 Compare December 14, 2023 17:45
@tdekoning93
Copy link
Contributor Author

Highly appreciated if you could have a look @artem-sidorenko

@schurzi
Copy link
Contributor

schurzi commented Dec 20, 2023

@tdekoning93 changes and tests looking good, can you solve the cookstyle issues, then I will merge it.

@tdekoning93 tdekoning93 force-pushed the feature/allow_more_changes_auditd branch from 291cc9a to fee22ba Compare December 21, 2023 08:41
artem-sidorenko and others added 5 commits December 21, 2023 09:42
Signed-off-by: Artem Sidorenko <[email protected]>
Signed-off-by: Tim de Koning <[email protected]>
Signed-off-by: Artem Sidorenko <[email protected]>
Signed-off-by: Tim de Koning <[email protected]>
Signed-off-by: Emmanuel Iturbide <[email protected]>
Signed-off-by: Tim de Koning <[email protected]>
Default space_left_action was SYSLOG and admin_space_left_action was SUSPEND

Signed-off-by: Tim de Koning <[email protected]>
Signed-off-by: Tim de Koning <[email protected]>
@tdekoning93 tdekoning93 force-pushed the feature/allow_more_changes_auditd branch from ab38d00 to a197f2c Compare December 21, 2023 08:43
@tdekoning93
Copy link
Contributor Author

Done @schurzi

@schurzi schurzi enabled auto-merge December 21, 2023 09:43
@schurzi schurzi disabled auto-merge December 21, 2023 09:49
@schurzi schurzi merged commit b78f440 into dev-sec:master Dec 21, 2023
39 of 50 checks passed
@tdekoning93
Copy link
Contributor Author

@schurzi Thanks for merging! Can you also maybe make a new release? Currently I'm still grabbing latest, which is 4.1.2

@dev-sec-bot dev-sec-bot mentioned this pull request Dec 22, 2023
@schurzi
Copy link
Contributor

schurzi commented Dec 22, 2023

@schurzi Thanks for merging! Can you also maybe make a new release? Currently I'm still grabbing latest, which is 4.1.2

v4.2.0 is released now

@artem-sidorenko
Copy link
Member

artem-sidorenko commented Feb 9, 2024

@schurzi many thanks for taking care :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants