Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1 updates to match benchmark v2 #83

Closed
wants to merge 1 commit into from

Conversation

deric4
Copy link
Member

@deric4 deric4 commented Aug 4, 2020

No description provided.

@deric4 deric4 closed this Aug 4, 2020
@micheelengronne
Copy link
Member

@deric4 you closed the issue. Are you not satisfied of it ? To push the profile to v2 is interesting.

@micheelengronne
Copy link
Member

Related #67

@flyinbutrs
Copy link

Hi @micheelengronne - Logicworks is starting to update this inspec profile to DIL benchmark v2.0.0 for our own internal processes, and were planning to offer the end result as a PR. I suspect it'd be better to have a full PR with all 2.0.0 changes rather than having section by section PRs.

Thanks for pointing out #67, we'll try applying those patches and evaluate how close those get.

Some questions:

  1. Is it safe to assume there's no need for side-by-side support for both v1.x.x and v2.x.x versions of the CIS DIL specification?

  2. Is there any contribution guidelines (aside from apache license)?

  3. Would it be preferable to have it in one PR for all controls?

@chris-rock
Copy link
Member

@flyinbutrs That is awesome. Thank you.

  1. Since 2.0.0 is superseding 1.0.0, there is no need to support both version.

  2. All contributions are apache licensed and they need to be signed-off, that's all

  3. It depends. I assume it there are quite some changes. If those changes are non-breaking, we can merge them along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants