Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace M2Crypto with Cryptography #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shivaRamdeen
Copy link

resolves #59

@gcartlidge
Copy link

I was having trouble with the existing M2Crypto stuff (plus it's iffy to build if you can't find a pre-compiled one) where the signature wasn't working properly (the pass generated but wouldn't register on phone). Thought what the hell, let's try the cryptography one because it's easy to pip. Pulled this git, fixed my issues! Not exactly sure what it fixed, but my pkpass files work now!

Thanks! 👍

@shivaRamdeen
Copy link
Author

I was having trouble with the existing M2Crypto stuff (plus it's iffy to build if you can't find a pre-compiled one) where the signature wasn't working properly (the pass generated but wouldn't register on phone). Thought what the hell, let's try the cryptography one because it's easy to pip. Pulled this git, fixed my issues! Not exactly sure what it fixed, but my pkpass files work now!

Thanks! 👍

Glad it worked for you. Hopefully this PR gets merged soon so everyone can migrate. Cheers.

@mbaechtold
Copy link
Collaborator

This is just a first reaction where I'd like to thank you for your pull request. I'll try to have a look at it soon.

@NathanQ
Copy link

NathanQ commented Feb 1, 2022

@shivaRamdeen
Copy link
Author

@mbaechtold Any headway with this PR?

@sokolx1
Copy link

sokolx1 commented Sep 30, 2022

resolves #59

Well, maybe i dont understand something. Do i have to change my key generation somehow, in order for this to work?

cryptography does not support the file, that is generated with this command:

openssl pkcs12 -in "Certificates.p12" -nocerts -out private.key

any workarounds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace M2Crypto with cryptography
5 participants