-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace M2Crypto with Cryptography #60
base: master
Are you sure you want to change the base?
Conversation
I was having trouble with the existing M2Crypto stuff (plus it's iffy to build if you can't find a pre-compiled one) where the signature wasn't working properly (the pass generated but wouldn't register on phone). Thought what the hell, let's try the cryptography one because it's easy to pip. Pulled this git, fixed my issues! Not exactly sure what it fixed, but my pkpass files work now! Thanks! 👍 |
Glad it worked for you. Hopefully this PR gets merged soon so everyone can migrate. Cheers. |
This is just a first reaction where I'd like to thank you for your pull request. I'll try to have a look at it soon. |
is test_signing() awaiting M2Crypto replacement? https://github.com/devartis/passbook/pull/60/files#diff-5b9b40c808949b2c3451e00cc35167849bcc2f0e4cb59c821a58c0a01936cb63R132 |
@mbaechtold Any headway with this PR? |
Well, maybe i dont understand something. Do i have to change my key generation somehow, in order for this to work? cryptography does not support the file, that is generated with this command: openssl pkcs12 -in "Certificates.p12" -nocerts -out private.key any workarounds? |
resolves #59