fix: respect user-defined PIPX_BIN_DIR #641
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pipx is already installed in the base image, it's likely that PIPX_BIN_DIR is set to a custom location such as
/usr/local/bin
. Since this script doesn't yet support--global
, this at least adds support for user-defined PIPX_BIN_DIRs. Without this support, the script would create broken symlinks, e.g. when installingghcr.io/prulloac/devcontainer-features/pre-commit:1
andPIPX_BIN_DIR=/usr/local/bin
andPIPX_HOME=/opt/pipx
, pipx installs the pre-commit symlink to/opt/pipx/bin/pre-commit
, which results in a broken symlink: