Add extend access token request #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few decisions made here that were a little bit beyond just adding this request:
Upgrade the test project to .net core 3.1 since the .net core 2.2 library is not supported by ms anymore. I went to install .net core 2.2, but it was just redirecting me to the latest version. It couldn't run the tests without this change
I refactored the FacebookClient.GetAsync method to be a little more readable since that was the part of the code that took me the longest to understand.
In Facebookclient.SerializeResponse I made it so the actual Facebook error was throw so that error messages are more informative. This was quite helpful for me as I added extra tests.