Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MUI font and icons to index.html #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasonvasquez
Copy link
Member

MaterialUI by default uses Roboto and the Material Icons. This change introduces those two resources to the template index.html.

@@ -20,6 +20,8 @@
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500,700&display=swap" />
<link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am honestly a little torn on this. This is super simple but does have the potential disadvantage that we are dependent on the external cdn for the app to look right (google should be up but what if it isn't).

Thoughts on using something like this https://github.com/fontsource/fontsource to include these fonts in the bundle?

//fonts.ts

import "fontsource-roboto";
import "fontsource-material-icons";

theme.ts

import "./fonts";

// do material theme things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants