Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General cleanup #32

Merged
merged 5 commits into from
Oct 9, 2024
Merged

General cleanup #32

merged 5 commits into from
Oct 9, 2024

Conversation

gadomski
Copy link
Collaborator

@gadomski gadomski commented Oct 9, 2024

What I am changing

  • Nits, chores, and such

How I did it

  • Update the CI to hit the entire workspace more
  • Fix a nit or two that was missed in the python crate
  • Add more denies and a warn to the core lib

Related Issues

@gadomski gadomski requested a review from bitner October 9, 2024 10:14
@gadomski gadomski self-assigned this Oct 9, 2024
@gadomski gadomski enabled auto-merge (rebase) October 9, 2024 10:16
@gadomski gadomski merged commit b787e52 into main Oct 9, 2024
18 checks passed
@gadomski gadomski deleted the cleanup branch October 9, 2024 14:03
@@ -22,10 +22,10 @@ jobs:
components: rustfmt, clippy
- uses: Swatinem/rust-cache@v2
- name: cargo fmt
run: cargo fmt -- --check
run: cargo fmt --all --check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I look at

cargo check --help

it says that --all is deprecated

Package Selection:
      --all               Alias for --workspace (deprecated)

Maybe switch to --workspace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test README code
3 participants