Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packaging #51

Merged
merged 7 commits into from
Dec 9, 2024
Merged

fix: packaging #51

merged 7 commits into from
Dec 9, 2024

Conversation

gadomski
Copy link
Collaborator

@gadomski gadomski commented Dec 9, 2024

What I am changing

  • Fix packaging issues caused by a dummy top-level pyproject.toml

cc @alukach

How I did it

  • Move our Python's pyproject.toml to the top level
  • Add the doc dependencies to our Python package's pyproject.toml
  • Add some Scripts To Rule Them All (STRTA)
  • Use STRTA to simplify our CI
  • Fix a small clippy nit

How you can test it

uv sync
scripts/test

Related Issues

@gadomski gadomski requested a review from kylebarron December 9, 2024 13:23
@gadomski gadomski self-assigned this Dec 9, 2024
Copy link
Member

@kylebarron kylebarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like having the pyproject.toml in the same python package just to clarify which pyproject.toml is associated with which Python binding, but it's ok to diverge from that.

scripts/test Outdated Show resolved Hide resolved
@gadomski
Copy link
Collaborator Author

gadomski commented Dec 9, 2024

I personally like having the pyproject.toml in the same python package just to clarify which pyproject.toml is associated with which Python binding, but it's ok to diverge from that.

I started that way as well, but I found that I wanted to tell folks to uv sync && uv run pytest or whatever, and a top-level pyproject.toml seemed to be the cleanest way.

@gadomski gadomski enabled auto-merge (squash) December 9, 2024 17:47
@gadomski gadomski merged commit ef4b6d0 into main Dec 9, 2024
1 check passed
@gadomski gadomski deleted the issues/50-build-on-install branch December 9, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install issues with uv
2 participants