Libify validation #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Returns `Result<()>` instead of bools from validation method - Removes `validate_str` - Adds crate-specific error based on `thiserror` - Adds some doctests
|
@gadomski I tried to merge most of the stuff you had in taking into account the changes I had made, I think that I conceptually at least got most of the stuff you had done in there, but there may be some other things that will need another PR. I'll wait for the thumbs up from you to merge this one. |
|
@gadomski The inline testing of the doc examples is crazy slick! |
gadomski
requested changes
Jul 25, 2024
gadomski
approved these changes
Jul 25, 2024
|
@bitner fysa I'm working on another PR that will change the |
|
@gadomski I'm done working on this for the week, so no worries about any more crossed PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge in changes from #4