Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update units for effectiveCacheSize and tempBuffers #112

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

hrodmn
Copy link
Contributor

@hrodmn hrodmn commented Dec 9, 2024

⚠️ Checklist if your PR is changing anything else than documentation

  • Posted the link to a successful manually triggered deployment workflow (successful including the resources destruction)

Merge request description

The effectiveCacheSize and tempBuffers parameters need to be described in number of 8kb blocks like sharedBuffers.
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Appendix.PostgreSQL.CommonDBATasks.Parameters.html

Successful deployment workflow run: https://github.com/developmentseed/eoapi-cdk/actions/runs/12241535813

@hrodmn hrodmn changed the title Fix: update units for effectiveCacheSize and tempBuffers fix: update units for effectiveCacheSize and tempBuffers Dec 9, 2024
@hrodmn hrodmn force-pushed the fix/update-parameter-group branch from 0a9c1b3 to 1064c7f Compare December 9, 2024 18:02
Copy link
Member

@alukach alukach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches what the documentation describes (thanks for linking).

How did you come across this issue? Did this cause you problems?

Is it safe to say that existing eoapi-cdk deployments' effective_cache_size and temp_buffers are thus over-provisioned 8-fold?

@hrodmn
Copy link
Contributor Author

hrodmn commented Dec 9, 2024

Thanks for the review @alukach!

How did you come across this issue? Did this cause you problems?

I don't know if it is the source of my issue, but I have been trying to improve performance on the MAAP eoAPI deployment by adding a pgbouncer instance between the titiler-pgstac Lambda and the RDS instance. While trying to determine some good pgbouncer settings for the t3.micro RDS instance, I was looking at the database configuration parameters and saw that effective_cache_size was 6GB for my 1GB instance!

Is it safe to say that existing eoapi-cdk deployments' effective_cache_size and temp_buffers are thus over-provisioned 8-fold?

Yes I think any deployment that is not overriding the default has effective_cache_size that is 8x higher than we want.

@hrodmn hrodmn merged commit 2e3d728 into main Dec 10, 2024
6 checks passed
@hrodmn hrodmn deleted the fix/update-parameter-group branch December 10, 2024 12:28
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
# [7.3.0](v7.2.1...v7.3.0) (2024-12-10)

### Bug Fixes

* update units for effectiveCacheSize and tempBuffers ([#112](#112)) ([2e3d728](2e3d728))

### Features

* set search_path to include pgstac for eoapi user ([#111](#111)) ([0470dcf](0470dcf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants