Use USWDS Page Footer #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
though I am not sure why this would be needed
✅ Deploy Preview for veda-ui-next-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
11 tasks
|
Note: In order for the deploy preview to work, we need to publish a version of the veda-ui library which includes the recent work on the footer. |
snmln
added a commit
to NASA-IMPACT/veda-ui
that referenced
this pull request
Jan 22, 2025
**Related Ticket:** #1135 ### Description of Changes TO DO: - [x] Create slim footer front-end, using USWDS. - [x] Pulling USWDS Styles. - [x] Connect to veda.config.js data. - [x] Setup USWDS feature flag. - [x] hideFooter functionality (props) - [x] Fix Nasa svg file to not rely on css translate. - [x] Checkin with Fausto on progress. - [x] Import into and use in next-veda-ui (NASA-IMPACT/next-veda-ui#26) - [ ] Connect to instance theme styling (font, color, etc.) - [x] Ensure styling looks as expected on next-veda-ui - [x] Add Feature Flag documentation ### Notes & Questions About Changes _{Add additonal notes and outstanding questions here related to changes in this pull request}_ ### Validation / Testing _{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related branch on veda-ui:
1135-Refactor-Layout-Components-FooterRelated PR on veda-ui: NASA-IMPACT/veda-ui#1285
Using the USWDS page footer with some default footer settings and reusing the nav items from page header/nav component.
Why would we need to mark the component with 'use client'? The footer crashes the build otherwise, need to investigate whats going on.
Also, interesting to see what styling issues we still need to tackle!