[FEATURE BRANCH] 902 Add E&A #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui-next-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Sep 17, 2024
Closed
sandrahoang686
force-pushed
the
902-add-ea
branch
from
c9c2bc0 to
a0b8f7d
Compare
|
Not sure if this is due to this PR for E&A or if it's due to other things in the next.js instance, but I see some weird scrolling behavior where I can't scroll down all the way in the timeline panel at the bottom without moving the entire E&A tool up, see the video below scrolling.in.next.js.EnA.mp4Otherwise, I haven't found many issues. There is definitely different charting behavior on the data layers I have been able to generate analyses for (also see in the video) but I'm not sure if that's accidental or some addition to the charting library that I wasn't aware of? |
sandrahoang686
added a commit
to NASA-IMPACT/veda-ui
that referenced
this pull request
Nov 13, 2024
**Related Ticket:** #1154 ### Description of Changes * Fixed to have changes from https://github.com/NASA-IMPACT/veda-ui/pull/1231/files# which I accidentally removed when resolving conflicts in main feature branch * Remove `onClick` from `LinkProperties` * When something is a link, it doesn't need an onClick event... The onClick event should be placed on the `Card` Component instead of link props * LinkProperties should not be required for the card component. Only when the card re-routes would it need the linkProperties. For example, cards on the dataset selector modal dont re-route and we shouldn't have to pass in linkProps * Remove try/catch around aoi area/point selection logic and into local state with useEffect ### Note Built `v5.9.1-ea.0` off of these changes Update: Bulit `v5.9.1-ea.1` has been built ### Validation / Testing * Please make sure Dataset Layer Selection modal and E&A works as expected * Please make sure all cards in the dashboard are working as expected * Make sure external cards link externally and have the external badge * Make sure internal cards link internally correctly * Make sure Dataset Layer Selection modal selects cards as expected **NextJs Preview with updated version:** developmentseed/next-veda-ui#4
|
@aboydnw thank you for validation 🙏🏼. Yeah, i left a comment about that in my description but haven't been able to dig into it just yet. Scrolling one is new to me, thanks for catching 👀. Would you be fine with ticketing those bugs to unblock merging these bigger feature branch PRs? We should definitely work on those as fast followups though |
|
@sandrahoang686 and I caught up on this and I'll ticket these issues. good to go for now |
sandrahoang686
added a commit
to NASA-IMPACT/veda-ui
that referenced
this pull request
Nov 14, 2024
**Related Ticket:** #902 ### Description of Changes **Related NextJs PR/Branch:** developmentseed/next-veda-ui#4 **GHG Preview** with this branch pulled in generated here => US-GHG-Center/veda-config-ghg#659 **Iteration 1** - Issue #902, changes by @sandrahoang686 * Exposed `ExplorationAndAnalysis` component * Exposed `timelineDatasetsAtom` to be used NextJs side * Exposed & Moved/decoupled `DatasetSelectorModal` out of `ExplorationAndAnalysis`. ExplorationAndAnalysis only needs to know the dataset layers to be displayed. DatasetSelectorModal or whatever layer selection method should be controlled at the parent level above `ExplorationAndAnalysis`. * Commented out certain controls that were breaking `ExplorationAndAnalysis` in NextJs instance * `AnalysisMessageControl` * `CustomAoIControl` ### Notes & Questions About Changes _{Add additonal notes and outstanding questions here related to changes in this pull request}_ ### Validation / Testing * Validate that Datalayer Selection Modal works as expected * Validate that E&A features work as expected - aois, analyzation, adding/removing cards * Validate that all card linking works as expected
1 task
2 tasks
dzole0311
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue: NASA-IMPACT/veda-ui#1154
Related PRs:
#4
Will need to update library version when veda-ui feature branch PR is good to go
Validation:
Note: