Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bytes pr draft #157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jessekrubin
Copy link

Currently copy-pasta-ed the pyo3-bytes impl and will PR into there once I get thoughts from @kylebarron.

Something is super screwy in the decode function

Tests are in ry/tests/test_bytes.py and a a bit crude

Key Additions:

  • slicing in __getItem__
  • hex function
  • attempt at decode
  • the __repr__ string returns a string that should eval to an equal Bytes obj (i dont think it is technically identical to how python's builtin bytes do stringifying but it works (see tests))

@jessekrubin jessekrubin marked this pull request as ready for review January 17, 2025 19:05
@kylebarron
Copy link
Member

Thanks! I'm about to go on vacation for a few days, so I probably won't have time to review this until Wednesday

@jessekrubin
Copy link
Author

Happy vacation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants