fix env var name for id key - OSM_id_key -> OPENSTREETMAP_id_key #303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Rub21 I think this env var needs to be OPENSTREETMAP_id_key, looking at https://github.com/developmentseed/osm-seed/blob/develop/images/web/start.sh#L31
I think we might have forgotten to update the example env after making these variable name changes recently?
Also, am not sure if we also need to change the OSM_memcache_servers variable name similarly at https://github.com/developmentseed/osm-seed/blob/develop/envs/.env.web.example#L29 ? I remember there being some changes we made to these names some point when upstream made some changes, but I forget the details a bit. Could you see if this makes sense and make any other changes to the env example I might have missed and we can merge this?
cc @majdal