Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix env var name for id key - OSM_id_key -> OPENSTREETMAP_id_key #303

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

batpad
Copy link
Member

@batpad batpad commented Nov 27, 2023

@Rub21 I think this env var needs to be OPENSTREETMAP_id_key, looking at https://github.com/developmentseed/osm-seed/blob/develop/images/web/start.sh#L31

I think we might have forgotten to update the example env after making these variable name changes recently?

Also, am not sure if we also need to change the OSM_memcache_servers variable name similarly at https://github.com/developmentseed/osm-seed/blob/develop/envs/.env.web.example#L29 ? I remember there being some changes we made to these names some point when upstream made some changes, but I forget the details a bit. Could you see if this makes sense and make any other changes to the env example I might have missed and we can merge this?

cc @majdal

@batpad batpad requested a review from Rub21 November 27, 2023 07:49
@majdal
Copy link

majdal commented Nov 27, 2023

I would also add something in the readme of that file that explains that iD editor is also being installed as a part of the package.

@majdal
Copy link

majdal commented Nov 27, 2023

ALSO: seems like Google disabled the "allow less secure apps" option on gmail accounts as of last year, so as far as I can tell, the gmail option for email is no longer available... https://github.com/developmentseed/osm-seed/tree/develop/images/web#email-configuration

@Rub21 Rub21 merged commit f87b744 into develop Feb 16, 2024
1 check passed
@Rub21 Rub21 deleted the fix/osm-id-env branch October 5, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants