Merge pull request #356 from developmentseed/fix/resolve-member-names

Make sure user ids are integers when resolving member names
developmentseed · Dec 23, 2022 · 0885362 · 0885362
2 parents 2dde70b + b54cbea
commit 0885362
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/models/team.js b/src/models/team.js
@@ -66,10 +66,13 @@ const teamAttributes = [
  *
  */
 async function resolveMemberNames(ids) {
+  // TODO Quick fix, we need to do proper type validation
+  const userIds = ids.map((i) => parseInt(i))
+
   // get the display names from the database table first
-  const foundUsers = await db('osm_users').whereIn('id', ids)
+  const foundUsers = await db('osm_users').whereIn('id', userIds)
   const foundUserIds = foundUsers.map(prop('id'))
-  const notFound = difference(ids, foundUserIds)
+  const notFound = difference(userIds, foundUserIds)
 
   let usersFromOSM = []
   if (notFound.length > 0) {