Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render of private organization teams on public organization page causes crash #351

Closed
LanesGood opened this issue Dec 19, 2022 · 1 comment
Labels
Type: Bug Something isn't working

Comments

@LanesGood
Copy link
Member

Problem

The YouthMappers organization page is failing. Page crashes with error Application error: a client-side exception has occurred (see the browser console for more information).

TypeError: a.map is not a function
    at T.renderOrgTeams ([id]-f2c17e1f3fe23fa9.js:1:3843)
    at T.render ([id]-f2c17e1f3fe23fa9.js:1:8867)
    at uh (framework-2fe4cb6473b20297.js:9:75833)

I believe that the renderOrgTeams() method introduced in #329 is causing organization pages to fail when a user does not have the proper access to view the teams associated with an organization.

Additionally, the YouthMappers organization is private. As a non-member, I should not be able to view this page.

Solution:

The application should not render any private teams in the organization teams list on a public organization page.

@LanesGood LanesGood added the Type: Bug Something isn't working label Dec 19, 2022
@LanesGood
Copy link
Member Author

This is no longer present. Users instead see an "Unauthorized" page - we'll explore fixing this in #428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant