-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination to organization page #353
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # README.md # src/models/team.js
This is ready for a first review. Changes added:
Know issues:
What to test at this point:
|
Status update: I fixed the regressions in models and reinstated the actions for org/manager. I expect the app should work without major issues. How to test:
@LanesGood @batpad @kamicut this is ready for review. |
I was able to add staff members to a new organization, add new teams, add new members to those teams, and promote and demote org staff and team members. I hit an error with the organization page loading due to a failed request to the paginated staff members list when adding non-existent OSM member id's to the staff members, but I ticketed the failure of adding non-existent members in #355. I don't know if there is a related bug we should catch here. I get an error toast when I try to create a badge, but there are no failed requests in the network tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are issues with the badge page, but that's because we now paginated the response for organization members. We should tackle that in a separate PR.
The main goal of this PR is to add pagination to all tables of the organization page. This is WIP.
Contributes to #319.
cc @LanesGood @kamicut @batpad