Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to organization page #353

Merged
merged 25 commits into from
Dec 23, 2022
Merged

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented Dec 20, 2022

The main goal of this PR is to add pagination to all tables of the organization page. This is WIP.

Contributes to #319.

cc @LanesGood @kamicut @batpad

@vercel
Copy link

vercel bot commented Dec 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
osm-teams ✅ Ready (Inspect) Visit Preview Dec 23, 2022 at 8:45AM (UTC)

Base automatically changed from add/generic-teams-table to develop December 21, 2022 08:52
@vgeorge vgeorge marked this pull request as ready for review December 21, 2022 17:28
@vgeorge
Copy link
Member Author

vgeorge commented Dec 21, 2022

This is ready for a first review. Changes added:

Know issues:

  • This doesn't include pagination for badges, to be added in a separate PR
  • I introduced regressions by changing methods of Team and Organization models, which broke other parts of the app not covered by tests, like the team creation page. I have a potential fix for this and will add to this PR later.
  • Owner/manager promote/demote actions in the org page are also broken, due to the reason above

What to test at this point:

cc @LanesGood @kamicut @batpad

@vgeorge
Copy link
Member Author

vgeorge commented Dec 22, 2022

Status update: I fixed the regressions in models and reinstated the actions for org/manager. I expect the app should work without major issues.

How to test:

  • Open organization spec in Cypress dashboard, interact with pagination component
  • Run the app in development mode and try creating teams/orgs, promoting/demoting users

@LanesGood @batpad @kamicut this is ready for review.

@LanesGood
Copy link
Member

I was able to add staff members to a new organization, add new teams, add new members to those teams, and promote and demote org staff and team members.

I hit an error with the organization page loading due to a failed request to the paginated staff members list when adding non-existent OSM member id's to the staff members, but I ticketed the failure of adding non-existent members in #355. I don't know if there is a related bug we should catch here.

I get an error toast when I try to create a badge, but there are no failed requests in the network tab.

Copy link
Member

@kamicut kamicut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are issues with the badge page, but that's because we now paginated the response for organization members. We should tackle that in a separate PR.

@vgeorge vgeorge merged commit 2dde70b into develop Dec 23, 2022
@vgeorge vgeorge deleted the add/org-page-pagination branch December 23, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants