Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badges routes #247

Merged
merged 11 commits into from
Mar 14, 2022
Merged

Add badges routes #247

merged 11 commits into from
Mar 14, 2022

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented Feb 23, 2022

What I am changing

API routes for managing and fetching organization badges.

How I did it

This is WIP. To do list:

  • Badges spec
  • Badges migration
  • POST /badge
  • PUT /badge
  • DELETE /badge
  • POST /user/:id/badge
  • PUT /user/:id/badge
  • DELETE /user/:id/badge

Other notable changes introduced:

  • Schema validation with Yup
  • All tables are dropped at spec start, for two reasons:
    • Rolling back after the spec might not happen and break next spec run
    • In case test fails, data will be still available in test-db for inspection

How you can test it

Running tests, doc review.

Related Issues

Base automatically changed from fix/dev-instructions to develop February 23, 2022 13:36
@vgeorge vgeorge marked this pull request as ready for review March 8, 2022 10:55
@vgeorge vgeorge requested a review from kamicut March 8, 2022 10:55
@vgeorge
Copy link
Member Author

vgeorge commented Mar 8, 2022

@kamicut this is ready for review. I suggest looking into badges spec file, which should cover testing all added routes.

@vgeorge vgeorge merged commit cc2fa4e into develop Mar 14, 2022
@vgeorge vgeorge deleted the feature/badges branch March 14, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants