-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add badges management to organization view #256
Conversation
@kamicut ready for review. |
@kamicut I added badges assignment to this. How to test:
As this PR is getting too big I left some things out to include later in another PR:
|
@kamicut added a fix for the display name issues, please let me know if you can add members now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a 401 Unauthorized error that appears on the main organization dashboard when getting the badges for a user that is not part of an organization. This causes the page to error out to 401. We should catch the 401 and fail silently since it's an expected behavior, or delay the "get badges" call until we know the user has the correct permissions (if they are part of the owners list)
I recommend creating a second OSM user @vgeorge to test this type of behavior.
Otherwise, the PR is good to merge once this is fixed.
What I am changing
Adds the ability to manage badges in the organization page.
How I did it
This is WIP. Tasks:
This also includes a small lib
api-client.js
to avoid code repetition while interacting with the API.How you can test it
Run the development server and perform add/edit/remove badges actions.
Related Issues