Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve badge assignment #263

Merged
merged 6 commits into from
Apr 12, 2022
Merged

Improve badge assignment #263

merged 6 commits into from
Apr 12, 2022

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented Apr 11, 2022

This contributes to #240 by adding a page to add/update badges assignment. How to test:

  • Create/view org
  • Add members and/or staff
  • Create badge at org page
  • Open badge page by clicking it in badges table in org page
  • Enter OSM id or username in assign input, hit enter
  • If user is not part of organization a toast will be displayed
  • If user is part of org, badge assignment page is open
  • Set dates and submit, toast will be displayed on success/error

@kamicut there is a failing test related to API validation, but I think this is ready for a first review.

@vgeorge vgeorge requested a review from kamicut April 11, 2022 21:29
@vgeorge
Copy link
Member Author

vgeorge commented Apr 12, 2022

@kamicut tests are fixed now.

@vgeorge vgeorge merged commit 0051b7b into develop Apr 12, 2022
@vgeorge vgeorge deleted the enhance/edit-badge-assignment branch April 12, 2022 17:56
@vgeorge vgeorge mentioned this pull request Apr 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamicut kamicut kamicut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vgeorge @kamicut