Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badges to profile modal and other improvements #269

Merged
merged 8 commits into from
Apr 29, 2022

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented Apr 28, 2022

Contributes to #240.

How to test: assign badge to organization member, open member profile in organization page, it should list badges assigned.

@kamicut ready for review.

@vgeorge vgeorge requested a review from kamicut April 28, 2022 11:38
@vgeorge vgeorge changed the title Fetch and display badges in org profile modal Add badges to profile modal and other improvements Apr 29, 2022
@vgeorge
Copy link
Member Author

vgeorge commented Apr 29, 2022

@kamicut added the following changes to this:

  • Display validation error in new/edit badges assignment forms
  • Validate if the user already has the badge in assign new badge page (do not display generic error)
  • Remove assignment by id form in badge page
  • Format date always in UTC time
  • Badge update broken fix

How to test:

  • Try assigning a badge the user already has, a specific error toast should be displayed
  • Check if dates remains correct after assinging new or editing
  • Assign by osm id is no longer present in badge page

Ready for review.

@vgeorge vgeorge merged commit 1406af4 into develop Apr 29, 2022
@vgeorge vgeorge deleted the enhance/display-profile-badges branch April 29, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants