-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authenticated users can join public teams #90
Conversation
@sethvincent this isn't working for me. My console logs
EDIT: All good! My session details had not been updated. |
To add:
@kamicut @sethvincent should any of the above to-dos be included in this branch, or are these all separate issues? |
@LanesGood: |
Co-Authored-By: Lane Goodman <[email protected]>
Co-Authored-By: Lane Goodman <[email protected]>
@LanesGood i'll add 4 & 5 in this pr. 1 we should tackle as a more comprehensive toast/status message pr. That's kinda what this issue is for: #49 |
Change of plans: we'll also do 4 & 5 as a separate pr. Issue for that here: #94 |
closes #80
This adds a button for authenticated users to the team view page letting them join the team if they are not already in it.
It also adds a
Sign in to join team
button if the user has not yet logged in.All this is accomplished with an endpoint at
/api/teams/:id/join
that takes the user id of the current session and adds them to the team if allowed by theteam:join
permission. This is distinct from the endpoints for adding/updating members because it is assumed those are requested by team moderators. I think it makes sense forjoin
to be separate.If the user signs in with the
Sign in to join team
button it does not redirect them back to the team page. I think that would be an important thing to add. I am not yet sure how to accomplish that with this login flow, though. It might be best to make an issue for that and revisit it later.