add actions to test and deploy #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Jan 29, 2024
vincentsarago
commented
Jan 29, 2024
| run: npm run cdk -- deploy titiler-cmr-production --require-approval never | ||
| env: | ||
| # STACK_ALARM_EMAIL: ${{ secrets.ALARM_EMAIL }} | ||
| STACK_ROLE_ARN: ${{ secrets.role_arn }} |
There was a problem hiding this comment.
we need to store the arn in the secrets
vincentsarago
commented
Jan 29, 2024
.github/workflows/ci.yml
Outdated
| - name: Configure AWS credentials | ||
| uses: aws-actions/configure-aws-credentials@v2 | ||
| with: | ||
| role-to-assume: arn:aws:iam::444055461661:role/github-actions-role-eodc |
There was a problem hiding this comment.
I guess this is the arn to the veda account 🤷
we should add a comment
There was a problem hiding this comment.
I've moved this to the secrets
abarciauskas-bgse
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13