add /statistics, /feature, and /bbox endpoints #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrodmn
force-pushed
the
feature/add-statistics
branch
from
6fed76e to
426268d
Compare
vincentsarago
approved these changes
Oct 14, 2024
hrodmn
force-pushed
the
feature/add-statistics
branch
from
8e61733 to
8abcf4f
Compare
hrodmn
force-pushed
the
feature/add-statistics
branch
from
2f48b64 to
cf7c954
Compare
hrodmn
changed the title
|
@vincentsarago I know you already approved but do you want to take another quick look since I added the |
vincentsarago
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rasteriobackend worked out-of-the-box but thexarraybackend required a few small tweaks to which parameters get passed to the reader. The logic for handling options conditionally for each backend is kind of a mess, I would like to clean that up somehow but I tested the/statisticsendpoint on HLS data and MUR SST data and it works!Right now you can pass
max_size/height/widthto therasteriobackend but those args will be ignored forxarraybackend.Since they are so similar, I added the
/bboxand/featureendpoints, too.I was having some trouble reproducing the exact test behavior from my local environment in GH actions so I switched everything to use
uvfor installation/running things in CI and it worked the first time.Resolves #29