Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reader.py #52

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Update reader.py #52

merged 4 commits into from
Mar 21, 2024

Conversation

abarciauskas-bgse
Copy link
Contributor

@abarciauskas-bgse abarciauskas-bgse commented Mar 21, 2024 •
edited
Loading

checks that the CRS is 4326 before transforming coordinates

@vincentsarago
Copy link
Member

@abarciauskas-bgse can you limit the version of FastAPI to "fastapi>=0.100.0,<0.107.0"

ref developmentseed/titiler#746

@vincentsarago
Copy link
Member

there is also this issue that is going to be fixed in #51 https://github.com/developmentseed/titiler-xarray/pull/51/files#diff-9594314a973a963fe825ac5f6a9adbbb60f7e47980520d1f5ce01f8eb5b60dfcL541

@abarciauskas-bgse
Copy link
Contributor Author

@vincentsarago fastapi wasn't a dependency but I added it in 170b5e4, is that the right thing to do?

@vincentsarago
Copy link
Member

@abarciauskas-bgse Yes
This was fixed upstream in titiler but in version >0.15 while here we have titiler <0.15

@abarciauskas-bgse abarciauskas-bgse merged commit 9dbebea into dev Mar 21, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsarago vincentsarago vincentsarago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abarciauskas-bgse @vincentsarago