Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make redis and fakeredis optional dependencies #57

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from

Conversation

emileten
Copy link
Contributor

Partially addresses package size issue for lambda : #56

@emileten emileten requested a review from vincentsarago April 23, 2024 07:46
Copy link
Member

@vincentsarago vincentsarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emileten
Copy link
Contributor Author

Sure @vincentsarago I'll make that change in a bit. Also changing accordingly the infra code, will ping you. Thanks !

@emileten emileten requested a review from vincentsarago April 26, 2024 10:31
if settings.enable_cache:
titiler_env.update(
{"TITILER_XARRAY_CACHE_HOST": redis_cluster.attr_redis_endpoint_address}
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this block up, so we don't have 2 settings.enable_cache

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not-mandatory if you want to merge

@vincentsarago
Copy link
Member

@emileten do we have anything to do here before merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants