Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodata dependency to enable nodata overriding #66

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

vincentsarago
Copy link
Member

same as #65 but with dev as base 😅

@abarciauskas-bgse
Copy link
Contributor

Thanks @vincentsarago I tried to run the other branch and ran into some issues 😅 as I didn't realize it was based off (I think) an old version of dev. Should we close #65 ? (I'm actually not sure why it's not showing more differences, since it seems like it's based off an old version of dev, but I'm probably missing something obvious)

I tested this branch with a publicly accessible NetCDF from the POWER dataset and it is not throwing any errors (e.g. http://127.0.0.1:8000/tiles/WebMercatorQuad/0/0/0@1x?url=https%3A%2F%2Fpower-datastore.s3.amazonaws.com%2Fv9%2Fdaily%2F1985%2F04%2Fpower_901_daily_19850401_merra2_lst.nc&variable=PS&consolidated=false&rescale=90000%2C103000&colormap_name=cool&nodata=100000) but this is not a good test dataset for this feature. Wondering if @ciaransweet has a dataset and nodata value in mind to test.

@vincentsarago
Copy link
Member Author

(I'm actually not sure why it's not showing more differences, since it seems like it's based off an old version of dev, but I'm probably missing something obvious)

@abarciauskas-bgse, here is my git log output and it shows that my commit follows the last one made in dev 🤷

git log

commit 48476bfe29b51ed218e7751a9e2a7b59d4063ef0 (HEAD -> path/enable-nodata-override-v2, origin/path/enable-nodata-override-v2)
Author: vincentsarago <[email protected]>
Date:   Thu Sep 5 18:53:34 2024 +0200

    add nodata dependency to enable nodata overriding

commit 940c559e811418d068a1ead5fd4274221087c264 (origin/dev, dev)
Merge: 2be19eb e57c4ae
Author: Jonas <[email protected]>
Date:   Fri Aug 16 13:17:31 2024 +0200

    Merge pull request #61 from developmentseed/fix/readme-install-commands
    
    Fix install command order

@vincentsarago
Copy link
Member Author

@vincentsarago vincentsarago marked this pull request as ready for review October 8, 2024 07:45
@vincentsarago vincentsarago merged commit 05d97c9 into dev Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants