reduce endpoint name length limitation to 15 chars, validate on port …

…duplication (#702) * update validation & schema Signed-off-by: Stephanie <[email protected]> * fix build error Signed-off-by: Stephanie <[email protected]> * update generater to only shorten endpoint name length limit in devfile spec Signed-off-by: Stephanie <[email protected]> * fix api test Signed-off-by: Stephanie <[email protected]>
devfile · Jan 17, 2022 · 6e6e6a8 · 6e6e6a8
1 parent dd1d65d
commit 6e6e6a8
Show file tree

Hide file tree

Showing 31 changed files with 342 additions and 90 deletions.
diff --git a/crds/workspace.devfile.io_devworkspaces.v1beta1.yaml b/crds/workspace.devfile.io_devworkspaces.v1beta1.yaml
@@ -454,6 +454,7 @@ spec:
                                     `wss`.
                                   type: boolean
                                 targetPort:
+                                  description: The port number should be unique.
                                   type: integer
                               required:
                               - name
@@ -751,6 +752,7 @@ spec:
                                     `wss`.
                                   type: boolean
                                 targetPort:
+                                  description: The port number should be unique.
                                   type: integer
                               required:
                               - name
@@ -869,6 +871,7 @@ spec:
                                     `wss`.
                                   type: boolean
                                 targetPort:
+                                  description: The port number should be unique.
                                   type: integer
                               required:
                               - name
@@ -1259,6 +1262,8 @@ spec:
                                               a protocol of `https` or `wss`.
                                             type: boolean
                                           targetPort:
+                                            description: The port number should be
+                                              unique.
                                             type: integer
                                         required:
                                         - name
@@ -1552,6 +1557,8 @@ spec:
                                               a protocol of `https` or `wss`.
                                             type: boolean
                                           targetPort:
+                                            description: The port number should be
+                                              unique.
                                             type: integer
                                         required:
                                         - name
@@ -1681,6 +1688,8 @@ spec:
                                               a protocol of `https` or `wss`.
                                             type: boolean
                                           targetPort:
+                                            description: The port number should be
+                                              unique.
                                             type: integer
                                         required:
                                         - name
@@ -2166,6 +2175,7 @@ spec:
                                         or `wss`.
                                       type: boolean
                                     targetPort:
+                                      description: The port number should be unique.
                                       type: integer
                                   required:
                                   - name
@@ -2442,6 +2452,7 @@ spec:
                                         or `wss`.
                                       type: boolean
                                     targetPort:
+                                      description: The port number should be unique.
                                       type: integer
                                   required:
                                   - name
@@ -2561,6 +2572,7 @@ spec:
                                         or `wss`.
                                       type: boolean
                                     targetPort:
+                                      description: The port number should be unique.
                                       type: integer
                                   required:
                                   - name
@@ -2965,6 +2977,8 @@ spec:
                                                   or `wss`.
                                                 type: boolean
                                               targetPort:
+                                                description: The port number should
+                                                  be unique.
                                                 type: integer
                                             required:
                                             - name
@@ -3276,6 +3290,8 @@ spec:
                                                   or `wss`.
                                                 type: boolean
                                               targetPort:
+                                                description: The port number should
+                                                  be unique.
                                                 type: integer
                                             required:
                                             - name
@@ -3412,6 +3428,8 @@ spec:
                                                   or `wss`.
                                                 type: boolean
                                               targetPort:
+                                                description: The port number should
+                                                  be unique.
                                                 type: integer
                                             required:
                                             - name

diff --git a/crds/workspace.devfile.io_devworkspaces.yaml b/crds/workspace.devfile.io_devworkspaces.yaml
@@ -462,6 +462,7 @@ spec:
                                       or `wss`.
                                     type: boolean
                                   targetPort:
+                                    description: The port number should be unique.
                                     type: integer
                                 required:
                                 - name
@@ -764,6 +765,7 @@ spec:
                                       or `wss`.
                                     type: boolean
                                   targetPort:
+                                    description: The port number should be unique.
                                     type: integer
                                 required:
                                 - name
@@ -885,6 +887,7 @@ spec:
                                       or `wss`.
                                     type: boolean
                                   targetPort:
+                                    description: The port number should be unique.
                                     type: integer
                                 required:
                                 - name
@@ -1282,6 +1285,8 @@ spec:
                                                 `wss`.
                                               type: boolean
                                             targetPort:
+                                              description: The port number should
+                                                be unique.
                                               type: integer
                                           required:
                                           - name
@@ -1583,6 +1588,8 @@ spec:
                                                 `wss`.
                                               type: boolean
                                             targetPort:
+                                              description: The port number should
+                                                be unique.
                                               type: integer
                                           required:
                                           - name
@@ -1715,6 +1722,8 @@ spec:
                                                 `wss`.
                                               type: boolean
                                             targetPort:
+                                              description: The port number should
+                                                be unique.
                                               type: integer
                                           required:
                                           - name
@@ -2203,6 +2212,7 @@ spec:
                                           protocol of `https` or `wss`.
                                         type: boolean
                                       targetPort:
+                                        description: The port number should be unique.
                                         type: integer
                                     required:
                                     - name
@@ -2484,6 +2494,7 @@ spec:
                                           protocol of `https` or `wss`.
                                         type: boolean
                                       targetPort:
+                                        description: The port number should be unique.
                                         type: integer
                                     required:
                                     - name
@@ -2605,6 +2616,7 @@ spec:
                                           protocol of `https` or `wss`.
                                         type: boolean
                                       targetPort:
+                                        description: The port number should be unique.
                                         type: integer
                                     required:
                                     - name
@@ -3017,6 +3029,8 @@ spec:
                                                     of `https` or `wss`.
                                                   type: boolean
                                                 targetPort:
+                                                  description: The port number should
+                                                    be unique.
                                                   type: integer
                                               required:
                                               - name
@@ -3332,6 +3346,8 @@ spec:
                                                     of `https` or `wss`.
                                                   type: boolean
                                                 targetPort:
+                                                  description: The port number should
+                                                    be unique.
                                                   type: integer
                                               required:
                                               - name
@@ -3471,6 +3487,8 @@ spec:
                                                     of `https` or `wss`.
                                                   type: boolean
                                                 targetPort:
+                                                  description: The port number should
+                                                    be unique.
                                                   type: integer
                                               required:
                                               - name

diff --git a/crds/workspace.devfile.io_devworkspacetemplates.v1beta1.yaml b/crds/workspace.devfile.io_devworkspacetemplates.v1beta1.yaml
@@ -419,6 +419,7 @@ spec:
                                 This requires a protocol of `https` or `wss`.
                               type: boolean
                             targetPort:
+                              description: The port number should be unique.
                               type: integer
                           required:
                           - name
@@ -710,6 +711,7 @@ spec:
                                 This requires a protocol of `https` or `wss`.
                               type: boolean
                             targetPort:
+                              description: The port number should be unique.
                               type: integer
                           required:
                           - name
@@ -822,6 +824,7 @@ spec:
                                 This requires a protocol of `https` or `wss`.
                               type: boolean
                             targetPort:
+                              description: The port number should be unique.
                               type: integer
                           required:
                           - name
@@ -1202,6 +1205,7 @@ spec:
                                           protocol of `https` or `wss`.
                                         type: boolean
                                       targetPort:
+                                        description: The port number should be unique.
                                         type: integer
                                     required:
                                     - name
@@ -1483,6 +1487,7 @@ spec:
                                           protocol of `https` or `wss`.
                                         type: boolean
                                       targetPort:
+                                        description: The port number should be unique.
                                         type: integer
                                     required:
                                     - name
@@ -1604,6 +1609,7 @@ spec:
                                           protocol of `https` or `wss`.
                                         type: boolean
                                       targetPort:
+                                        description: The port number should be unique.
                                         type: integer
                                     required:
                                     - name
@@ -2071,6 +2077,7 @@ spec:
                                     `wss`.
                                   type: boolean
                                 targetPort:
+                                  description: The port number should be unique.
                                   type: integer
                               required:
                               - name
@@ -2340,6 +2347,7 @@ spec:
                                     `wss`.
                                   type: boolean
                                 targetPort:
+                                  description: The port number should be unique.
                                   type: integer
                               required:
                               - name
@@ -2457,6 +2465,7 @@ spec:
                                     `wss`.
                                   type: boolean
                                 targetPort:
+                                  description: The port number should be unique.
                                   type: integer
                               required:
                               - name
@@ -2846,6 +2855,8 @@ spec:
                                               a protocol of `https` or `wss`.
                                             type: boolean
                                           targetPort:
+                                            description: The port number should be
+                                              unique.
                                             type: integer
                                         required:
                                         - name
@@ -3139,6 +3150,8 @@ spec:
                                               a protocol of `https` or `wss`.
                                             type: boolean
                                           targetPort:
+                                            description: The port number should be
+                                              unique.
                                             type: integer
                                         required:
                                         - name
@@ -3268,6 +3281,8 @@ spec:
                                               a protocol of `https` or `wss`.
                                             type: boolean
                                           targetPort:
+                                            description: The port number should be
+                                              unique.
                                             type: integer
                                         required:
                                         - name