-
Notifications
You must be signed in to change notification settings - Fork 64
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
docs: adding contribution guidelines (#823)
* docs: adding contribution guidelines Signed-off-by: Michael Hoang <[email protected]> * triggering ci workflow Signed-off-by: Michael Hoang <[email protected]>
- Loading branch information
1 parent
a87448d
commit d6e8681
Showing
2 changed files
with
64 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# Contributing | ||
|
||
Contributions are welcome! | ||
|
||
## Code of Conduct | ||
|
||
Before contributing to this repository for the first time, please review our project's [Code of Conduct](https://github.com/devfile/api/blob/main/CODE_OF_CONDUCT.md). | ||
|
||
## Getting Started | ||
|
||
### Issues | ||
|
||
- Open or search for [issues](https://github.com/devfile/api/issues) with the label `area/api`. | ||
|
||
- If a related issue doesn't exist, you can open a new issue using a relevant [issue form](https://github.com/devfile/api/issues/new/choose). You can tag issues with `/area api`. | ||
|
||
### Building | ||
|
||
To build the CRD and the various schemas, you don't need to install any pre-requisite apart from `docker`. | ||
In the root directory, just run the following command: | ||
|
||
``` | ||
./docker-run.sh ./build.sh | ||
``` | ||
|
||
### Testing | ||
|
||
Find more information about tests in the [testing document](test/README.md). | ||
|
||
``` | ||
# schemaTest approach | ||
cd test/v200/schemaTest | ||
go test -v | ||
``` | ||
|
||
``` | ||
# apiTest approach | ||
cd test/v200/apiTest | ||
go test -v | ||
``` | ||
|
||
### Pull Requests | ||
|
||
All commits must be signed off with the footer: | ||
|
||
``` | ||
Signed-off-by: First Lastname <[email protected]> | ||
``` | ||
|
||
Once you set your user.name and user.email in your git config, you can sign your commit automatically with git commit -s. When you think the code is ready for review, create a pull request and link the issue associated with it. | ||
|
||
Owners of the repository will watch out for and review new PRs. | ||
|
||
If comments have been given in a review, they have to be addressed before merging. | ||
|
||
After addressing review comments, don’t forget to add a comment in the PR afterward, so everyone gets notified by Github and knows to re-review. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters