Skip to content

Commit

Permalink
Helm Specs Update (#221)
Browse files Browse the repository at this point in the history
* update timeout values for index server and registry viewer

Signed-off-by: Jordan Dubrick <[email protected]>

* add securitycontext and remove env file

Signed-off-by: Jordan Dubrick <[email protected]>

---------

Signed-off-by: Jordan Dubrick <[email protected]>
  • Loading branch information
Jdubrick authored Mar 11, 2024
1 parent a61d432 commit 6215550
Showing 1 changed file with 11 additions and 15 deletions.
26 changes: 11 additions & 15 deletions deploy/chart/devfile-registry/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ spec:
release: "{{ .Release.Name }}"
heritage: "{{ .Release.Service }}"
spec:
{{- if .Values.persistence.enabled }}
securityContext:
runAsNonRoot: true
runAsUser: 1001
runAsGroup: 2001
fsGroup: 3001
{{- end }}
volumes:
- name: devfile-registry-storage
{{- if .Values.persistence.enabled }}
Expand All @@ -52,12 +59,6 @@ spec:
items:
- key: registry-config.yml
path: config.yml
- name: viewer-env-file
configMap:
name: {{ template "devfileregistry.fullname" . }}
items:
- key: .env.registry-viewer
path: .env.production
containers:
- image: "{{ .Values.devfileIndex.image }}:{{ .Values.devfileIndex.tag }}"
imagePullPolicy: {{ .Values.devfileIndex.imagePullPolicy }}
Expand Down Expand Up @@ -87,8 +88,8 @@ spec:
port: 3000
scheme: HTTP
initialDelaySeconds: 30
periodSeconds: 1
timeoutSeconds: 10
periodSeconds: 10
timeoutSeconds: 20
{{- end }}
resources:
limits:
Expand Down Expand Up @@ -121,15 +122,15 @@ spec:
scheme: HTTP
initialDelaySeconds: 15
periodSeconds: 10
timeoutSeconds: 3
timeoutSeconds: 20
readinessProbe:
httpGet:
path: /viewer
port: 3000
scheme: HTTP
initialDelaySeconds: 15
periodSeconds: 10
timeoutSeconds: 3
timeoutSeconds: 20
resources:
limits:
memory: {{ .Values.registryViewer.memoryLimit }}
Expand All @@ -147,11 +148,6 @@ spec:
"fqdn": "{{ template "devfileregistry.ingressUrl" . }}"
}
]
volumeMounts:
- name: viewer-env-file
mountPath: /app/.env.production
subPath: .env.production
readOnly: true
securityContext:
allowPrivilegeEscalation: false
runAsNonRoot: true
Expand Down

0 comments on commit 6215550

Please sign in to comment.