-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Go 1.19 #211
Update to Go 1.19 #211
Conversation
Signed-off-by: Michael Valdron <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-alpine AS base | ||
COPY --from=goreleaser-xx / / | ||
RUN apk add --no-cache file git | ||
FROM --platform=$BUILDPLATFORM tonistiigi/xx:${XX_VERSION} AS xx |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium library
Click Remediation section below to solve this issue
COPY --from=goreleaser-xx / / | ||
RUN apk add --no-cache file git | ||
FROM --platform=$BUILDPLATFORM tonistiigi/xx:${XX_VERSION} AS xx | ||
FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS base |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium library
Click Remediation section below to solve this issue
WORKDIR /go/src/github.com/docker/distribution | ||
|
||
FROM base AS version |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium library
Click Remediation section below to solve this issue
COPY --from=build /usr/local/bin/registry* / | ||
COPY --from=build /usr/bin/registry / | ||
|
||
FROM base AS releaser |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium library
Click Remediation section below to solve this issue
|
||
FROM alpine:3.14 | ||
FROM alpine:${ALPINE_VERSION} |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium library
Remediation tip: pin your Docker image by updating alpine to alpine@sha256:21dc6063fd678b478f57c0e13f47560d0ea4eeba26dfc947b2a4f81f686b9f45
Click Remediation section below for further remediation help
/hold Need to verify dependents. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
=======================================
Coverage 27.23% 27.23%
=======================================
Files 7 7
Lines 2012 2012
=======================================
Hits 548 548
Misses 1417 1417
Partials 47 47 ☔ View full report in Codecov by Sentry. |
Stale branch, refer to #212 for further updates on this. |
Please specify the area for this PR
What does does this PR do / why we need it:
Updates
registry-library
to Go 1.19 with dependency updates.Which issue(s) this PR fixes:
Fixes #?
devfile/api#1469
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: