Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.19 #211

Conversation

michael-valdron
Copy link
Member

Please specify the area for this PR

What does does this PR do / why we need it:

Updates registry-library to Go 1.19 with dependency updates.

Which issue(s) this PR fixes:

Fixes #?

devfile/api#1469

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <[email protected]>
@openshift-ci openshift-ci bot requested review from elsony and Jdubrick March 6, 2024 22:40
Copy link

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-alpine AS base
COPY --from=goreleaser-xx / /
RUN apk add --no-cache file git
FROM --platform=$BUILDPLATFORM tonistiigi/xx:${XX_VERSION} AS xx

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue
COPY --from=goreleaser-xx / /
RUN apk add --no-cache file git
FROM --platform=$BUILDPLATFORM tonistiigi/xx:${XX_VERSION} AS xx
FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS base

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue
WORKDIR /go/src/github.com/docker/distribution

FROM base AS version

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue
COPY --from=build /usr/local/bin/registry* /
COPY --from=build /usr/bin/registry /

FROM base AS releaser

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue

FROM alpine:3.14
FROM alpine:${ALPINE_VERSION}

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium library

score is 5: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating alpine to alpine@sha256:21dc6063fd678b478f57c0e13f47560d0ea4eeba26dfc947b2a4f81f686b9f45
Click Remediation section below for further remediation help
@michael-valdron
Copy link
Member Author

/hold

Need to verify dependents.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.23%. Comparing base (ffc3a09) to head (1077875).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   27.23%   27.23%           
=======================================
  Files           7        7           
  Lines        2012     2012           
=======================================
  Hits          548      548           
  Misses       1417     1417           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-valdron
Copy link
Member Author

Stale branch, refer to #212 for further updates on this.

@michael-valdron michael-valdron deleted the registry-library/golang-1-19 branch March 6, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant