-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor out io/ioutil
#224
Refactor out io/ioutil
#224
Conversation
Signed-off-by: Michael Valdron <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
+ Coverage 27.23% 27.27% +0.04%
==========================================
Files 7 7
Lines 2012 2009 -3
==========================================
Hits 548 548
+ Misses 1417 1414 -3
Partials 47 47 ☔ View full report in Codecov by Sentry. |
N/A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
What does does this PR do / why we need it:
Refactor out
io/ioutil
module as part of Go 1.19 upgrade #212.Which issue(s) this PR fixes:
Fixes #?
devfile/api#1469
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: