-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecated stacks filtering to registry-library #232
Add deprecated stacks filtering to registry-library #232
Conversation
@thepetk: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would reflect these changes in other areas as well (docs and testing):
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: Michael Valdron <[email protected]> Signed-off-by: thepetk <[email protected]>
Co-authored-by: Michael Valdron <[email protected]> Signed-off-by: thepetk <[email protected]>
8c52863
to
162cd73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the value of index/server/tests/registry/stacks/java-springboot/devfile.yaml#L9 to our sprintboot logo to get around this https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/spring.svg
Signed-off-by: thepetk <[email protected]>
I've added this change to all places where the icon was mentioned. Although I think better if we open an issue for a more permanent solution around this. I think a good approach here could be to try to gather all test resources into a single directory, shared between the modules of the repo. WDYT? |
Signed-off-by: thepetk <[email protected]>
@thepetk I agree, an issue should opened to do this instead, I'd suggest everything should use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
/area registry-library
What does does this PR do / why we need it:
After the implementation for https://github.com/api/issues/959 we have now the ability of filtering the registry index for deprecated or non deprecated stacks by adding a
deprecated=true/false
parameter in the URL.This PR updates the
registry-library
importing the same logic followed to the index server too.Which issue(s) this PR fixes:
Fixes devfile/api#1065
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: