Fix build and push scripts to allow Podman alias

[Jdubrick]

Please specify the area for this PR
Build scripts and documentation

What does does this PR do / why we need it:
This PR fixes an issue where running docker-build.sh and docker-push.sh from test/integration was not properly setting the Podman alias. This was due to setenv.sh not being able to expand its set alias back into the calling scripts environment. This was fixed with the addition of shopt -s expand_aliases to setenv.sh.

Additionally, when you run docker-push.sh it is looking for a command-line argument for the tag and that was not documented anywhere so I added a snippet for that to README.md.

This PR also removes shopt -s expand_aliases from build_registry.sh as it is no longer required. This is due to the alias expansion happening in the setenv.sh script.

The index/server build.sh and push.sh scripts were also updated to properly use Podman when USE_PODMAN is set to true.

Which issue(s) this PR fixes:

fixes devfile/api#1502
fixes devfile/api#1426

PR acceptance criteria:

• Test Coverage
  • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

• Does the REST API doc need to be updated with your changes?
• Does the registry library doc need to be updated with your changes?

How to test changes / Special notes to the reviewer:

1. Run export USE_PODMAN=true
2. cd into tests/integration
3. Run ./docker-build.sh and/or ./docker-push.sh <tag>
4. cd into index/server
5. Run ./build.sh and/or ./push.sh <tag>
6. From root run bash build_registry.sh

[michael-valdron]

Good find, this will help with a lot in fixing the remaining under registry-support!

I think with this, we should be able to remove this statement under build_registry.sh so that it uses the one under setenv.sh:

registry-support/build_registry.sh

Line 21 in 4f92146

shopt -s expand_aliases

[Jdubrick]

Good find, this will help with a lot in fixing the remaining under registry-support!

I think with this, we should be able to remove this statement under build_registry.sh so that it uses the one under setenv.sh:

registry-support/build_registry.sh

Line 21 in 4f92146

shopt -s expand_aliases

I agree. I think I am going to include devfile/api#1426 as part of this PR because it is an identical fix, I will also clean up build_registry.sh then as well.

@michael-valdron

[michael-valdron]

/lgtm

Tested docker-build.sh and docker-push.sh with USE_PODMAN=true set and works locally for me.

[Jdubrick]

FYI I updated the PR comment to reflect new changes with the additional changes to fix devfile/api#1426 as well. @thepetk @michael-valdron

[thepetk]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Jdubrick,michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment