Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow samples cache directory to be created if non-existent #239

Merged

Conversation

michael-valdron
Copy link
Member

Please specify the area for this PR

build-tools

What does does this PR do / why we need it:

Changes mkdir $samplesDir/$sample to mkdir -p $samplesDir/$sample to allow target cache directories which do not exist yet.

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#1553

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Run bash build-tools/cache_samples.sh extraDevfileEntries.yaml <non_existent_caching_path>

@openshift-ci openshift-ci bot requested review from Jdubrick and thepetk May 14, 2024 18:32
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@michael-valdron
Copy link
Member Author

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

N/A

@michael-valdron michael-valdron requested a review from Jdubrick May 14, 2024 21:27
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After these changes I was able to run it on MacOS

build-tools/cache_samples.sh Outdated Show resolved Hide resolved
build-tools/cache_samples.sh Show resolved Hide resolved
Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron michael-valdron force-pushed the fix/non-existent-samples-cache branch from f286f4e to c1320ac Compare May 15, 2024 18:45
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
Copy link

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 1e05c6f into devfile:main May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache_samples.sh should create cache directory if does not exist
2 participants