-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow samples cache directory to be created if non-existent #239
Allow samples cache directory to be created if non-existent #239
Conversation
Signed-off-by: Michael Valdron <[email protected]>
N/A |
Signed-off-by: Michael Valdron <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After these changes I was able to run it on MacOS
Co-authored-by: Jordan Dubrick <[email protected]> Signed-off-by: Michael Valdron <[email protected]>
f286f4e
to
c1320ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
build-tools
What does does this PR do / why we need it:
Changes
mkdir $samplesDir/$sample
tomkdir -p $samplesDir/$sample
to allow target cache directories which do not exist yet.Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1553
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
Run
bash build-tools/cache_samples.sh extraDevfileEntries.yaml <non_existent_caching_path>