Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ginkgo skip jhipster-online #507

Closed
wants to merge 7 commits into from

Conversation

maximilianoPizarro
Copy link
Contributor

Description of Changes

Just add jhipster-online version: 2.33.0 jump stack arguments to ginkgo test because fail in step with odo v3.

Jdubrick and others added 7 commits December 6, 2024 16:06
* update lifecycle doc for exernal stack providers

Signed-off-by: Jordan Dubrick <[email protected]>

* reword to remove rh explicit

Signed-off-by: Jordan Dubrick <[email protected]>

---------

Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
* jhipster-online

Signed-off-by: Maximiliano Pizarro <[email protected]>

* add hash base ubi jhipster-online

Signed-off-by: Maximiliano Pizarro <[email protected]>

* remove versions from jhipster-online

Signed-off-by: Maximiliano Pizarro <[email protected]>

* metadata language Java

Signed-off-by: Maximiliano Pizarro <[email protected]>

* add metadata projectType: springboot jhipster-online

Signed-off-by: Maximiliano Pizarro <[email protected]>

* add hash, rm dockerfile and divide command in steps

Signed-off-by: Maximiliano Pizarro <[email protected]>

* jhipster online isDefault run task

Signed-off-by: Maximiliano Pizarro <[email protected]>

* add JHipster stacks - On trial CODEOWNERS

Signed-off-by: Maximiliano Pizarro <[email protected]>

* CODEOWNERS

Signed-off-by: Maximiliano Pizarro <[email protected]>

* Update stacks/jhipster-online/stack.yaml

Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>

* jhipster-online remove versions seccion stack.yaml

Signed-off-by: Maximiliano Pizarro <[email protected]>

* remove version from devfile.yaml

Signed-off-by: Maximiliano Pizarro <[email protected]>

* remove stack.yaml file jhipster-online

Signed-off-by: Maximiliano Pizarro <[email protected]>

* stack.yaml without version

Signed-off-by: Maximiliano Pizarro <[email protected]>

---------

Signed-off-by: Maximiliano Pizarro <[email protected]>
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
* chore(deps): update github actions

Signed-off-by: redhat-renovate-bot <[email protected]>

* Revert login-action update

Signed-off-by: thepetk <[email protected]>

---------

Signed-off-by: redhat-renovate-bot <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: thepetk <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
…tag to v1-1731645406 (#499)

Signed-off-by: redhat-renovate-bot <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: red-hat-konflux <[email protected]>

Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Copy link

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maximilianoPizarro
Once this PR has been reviewed and has the lgtm label, please assign jdubrick for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Dec 6, 2024

Hi @maximilianoPizarro. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maximilianoPizarro I'd suggest updating your fork and then rebasing your branch to the new main as now I see some commits we have already merged :) It's a bit confusing atm what this PR adds.

@maximilianoPizarro
Copy link
Contributor Author

@maximilianoPizarro I'd suggest updating your fork and then rebasing your branch to the new main as now I see some commits we have already merged :) It's a bit confusing atm what this PR adds.

Only add --skip="stack: jhipster-online version: 2.23.0 starter: jhipster-online" from file tests/check_odov3.sh. Because fail in the step "with odo v3".

Example error in the last job:

https://github.com/devfile/registry/actions/runs/12200513685/job/34042081550

Summarizing 1 Failure:
[FAIL] test starter projects from devfile stacks [It] stack: jhipster-online version: 2.33.0 no_starter
/home/runner/work/registry/registry/tests/odov3/odo_test.go:192

Ran 72 of 167 Specs in 2171.384 seconds
FAIL! -- 71 Passed | 1 Failed | 0 Pending | 95 Skipped

If you add for me this line in other PR you can close this PR.

Commit:

c75e925

If you need git rebase let me know.

I remain attentive. Thanks!

@thepetk
Copy link
Contributor

thepetk commented Dec 9, 2024

If you need git rebase let me know.

Yeah I think it would be better and we can have a cleaner list of commits that this PR is introcuing (I guess it includes previous ones due to squashing the commits).

For the change, I agree it will avoid the current night run failures in odo 3. I had in mind to investigate the reason of the failure, so thanks for saving me the time :) :)

@maximilianoPizarro maximilianoPizarro closed this by deleting the head repository Dec 9, 2024
@maximilianoPizarro
Copy link
Contributor Author

If you need git rebase let me know.

Yeah I think it would be better and we can have a cleaner list of commits that this PR is introcuing (I guess it includes previous ones due to squashing the commits).

For the change, I agree it will avoid the current night run failures in odo 3. I had in mind to investigate the reason of the failure, so thanks for saving me the time :) :)

Sorry for the inconvenience caused.

I was generated new PR #508 with the clean commits. See you there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants