Added a prop for light mode in the tooltip #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prateek3255 this is ready for review! |
prateek3255
reviewed
Oct 1, 2020
|
@prateek3255 Ready for the review! Mentioning for visibility! 😃 |
prateek3255
requested changes
Oct 6, 2020
src/lib/index.tsx
Outdated
| backgroundColor: "white", | ||
| color: "black", | ||
| } | ||
|
|
||
| const tooltipBaseStyles: React.CSSProperties = { |
There was a problem hiding this comment.
Make this a function that accepts theme instead of creating another variable.
There was a problem hiding this comment.
You mean a function that takes theme as input and returns the properties of the theme.
in this case, if theme is light function should return {backgrondColor: "white", color: "black"}
updated Props table on Readme using typescript string literals fixes
|
Thanks for working on this @ankiiitraj |
|
@all-contributors please add @ankiiitraj for code |
|
I've put up a pull request to add @ankiiitraj! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Gif demonstration for changes!