Replace mixed return type with #[\ReturnTypeWillChange] #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to maintain compatibility with PHP >= 7.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya,
Use of mixed return type bumps PHP version requirement to >= 8.1, while the rest of the code is compatible with PHP >= 7.1. To maintain compatibility and suppress deprecation notices in PHP 8.1+, I've added the #[\ReturnTypeWillChange] attribute to the offsetGet method.
This attribute is used to indicate a planned change to the returned type, as PHP 9 will most likely enforce return types for interface methods like offsetGet. This ensures compatibility with PHP >= 7.1 while preparing for stricter type requirements in future PHP versions.