Merge branch 'TMS-935' into stage

devgeniem · Nov 20, 2023 · 1b3aa05 · 1b3aa05
2 parents 99334a3 + fffc980
commit 1b3aa05
Show file tree

Hide file tree

Showing 23 changed files with 365 additions and 400 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,3 +1,7 @@
+Severa-ID: 2108
+Severa-kuvaus: 
+Task: https://hiondigital.atlassian.net/browse/TMS-
+
 <!--- Provide a general summary of your changes in the Title above -->
 
 ## Description

diff --git a/CHANGELOG.MD b/CHANGELOG.MD
@@ -7,13 +7,36 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
-- TMS-970: Add image caption text to call-to-action and content-columns blocks.
+- TMS-935: Archive filter accessibility fixes
+
+## [1.53.0] - 2023-11-07
+
+### Added
+
 - TMS-950:
     - Empty check for phone repeater.
     - Place of business posts to block
     - Contacts styles & accessibility
 - TMS-974: Add recurring events to lists as single item.
 
+## [1.52.0] - 2023-10-23
+
+### Added
+
+- TMS-970: Add image caption text to call-to-action and content-columns blocks.
+
+## [1.51.0] - 2023-10-12
+
+### Fixed
+
+- TMS-934: Add screen-reader info for article categories.
+- TMS-936: Image carousel accessibility fixes
+- TMS-933: Modaal accessibility fixes
+
+## [1.50.0] - 2023-10-04
+
+- TMS-978: Add has-line-height-normal class
+
 ## [1.49.0] - 2023-09-15
 
 - TMS-962: Add Lunch Menus plugin caps to roles.

diff --git a/assets/scripts/image-carousel.js b/assets/scripts/image-carousel.js
@@ -88,7 +88,7 @@ export default class ImageCarousel {
                 asNavFor: '#' + modalCarousel.attr( 'data-slider-for' ),
                 prevArrow: buttons.prevArrow,
                 nextArrow: buttons.nextArrow,
-                regionLabel: translations.modal_carousel,
+                regionLabel: translations.browsing_images,
                 arrowsPlacement: 'afterSlides',
             } );
 
@@ -125,7 +125,9 @@ export default class ImageCarousel {
             // Make the centered image selectable, rest disabled.
             // This way user can't open the "wrong" image and get confused of the results.
             $( slick.$slider ).find( '.slick-slide button' ).removeAttr( 'disabled' );
+            $( slick.$slider ).find( '.slick-slide button' ).removeAttr( 'aria-hidden' );
             $( slick.$slider ).find( '.slick-slide:not(.slick-current) button' ).attr( 'disabled', '' );
+            $( slick.$slider ).find( '.slick-slide:not(.slick-current) button' ).attr( 'aria-hidden', 'true' );
 
             // Transalate Slick Slider stuff
             this.translateCarousels( translations );

diff --git a/assets/scripts/image.js b/assets/scripts/image.js
@@ -22,8 +22,8 @@ export default class Image {
             type: 'image',
             background_scroll: false,
             after_open: this.disableBackgroundItemFocusing,
-            accessible_title: window.s.modaal.accessible_title || 'Dialog Window - Close (Press escape to close)',
-            close_aria_label: window.s.modaal.close || 'Close (Press escape to close)',
+            accessible_title: window.s.modaal.accessible_title || 'Enlarged image',
+            close_aria_label: window.s.modaal.close || 'Close',
         } );
     }
 

diff --git a/assets/styles/base/_typography.scss b/assets/styles/base/_typography.scss
@@ -85,6 +85,10 @@ a {
     line-height: 1.1;
 }
 
+.has-line-height-normal {
+    line-height: 1.5;
+}
+
 .hyphenate {
     hyphens: auto;
 }

diff --git a/assets/styles/ui-components/_archive-filters.scss b/assets/styles/ui-components/_archive-filters.scss
@@ -1,15 +1,16 @@
 .archive-filters {
     &__select-container {
         display: flex;
-        flex-direction: column;
+        flex-direction: column-reverse;
         gap: $theme-spacing-oneandhalf;
 
         @include until($tablet) {
             width: 100%;
         }
 
         @include from($tablet) {
-            flex-direction: row;
+            flex-direction: unset;
+            flex-wrap: wrap-reverse;
         }
 
         select {
@@ -21,4 +22,8 @@
             }
         }
     }
+
+    &__description {
+        width: 100%;
+    }
 }