Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/json produce support #172

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

nanic
Copy link
Contributor

@nanic nanic commented Oct 19, 2023

Description

Support for produce with a json file is added, similar to csv we have to use --file in tandem with --file-type flag

Fixes #141 (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • the change is mentioned in the ## [Unreleased] section of CHANGELOG.md
  • the configuration yaml was changed and the example config in README.md was updated
  • a usage example was added to README.md
  • tests for the changes have been implemented (see: Testing your changes)

@d-rk d-rk force-pushed the feat/json-produce-support branch from d1ff847 to baf603c Compare November 10, 2023 07:44
@d-rk
Copy link
Collaborator

d-rk commented Nov 10, 2023

⚠️ I rebased your branch

@d-rk d-rk merged commit 8b14cca into deviceinsight:main Nov 10, 2023
6 checks passed
@d-rk
Copy link
Collaborator

d-rk commented Nov 10, 2023

@nanic thank you also for this PR. I just released a new version with your PRs included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consume from a Topic and produce to another
2 participants