Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature | Focus areas limit #1349

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Feature | Focus areas limit #1349

merged 2 commits into from
Oct 12, 2023

Conversation

ThatcherK
Copy link
Contributor

Ticket #1347

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for DIwebsite-redesign:

User Total reviews Time to review Total comments
edwinmp 1 6m 0

@ThatcherK ThatcherK force-pushed the feature/focus-areas branch from db1abbb to e6f1278 Compare October 12, 2023 07:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

akmiller01
akmiller01 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@akmiller01 akmiller01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I thought it might initially be an issue if these blocks were in a row and wrapped, but since they're vertical both on wide and small screens, removing the limit does not affect the styles at all.

@akmiller01
Copy link
Contributor

Just one note @ThatcherK this will automatically deploy on dev, but we will either need to manually deploy on prod or change the prod CICD to point to the new server. I have time this afternoon to manually deploy on prod if you need.

@ThatcherK ThatcherK merged commit f3b6c2d into develop Oct 12, 2023
@ThatcherK ThatcherK deleted the feature/focus-areas branch October 12, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akmiller01 akmiller01 akmiller01 approved these changes

@wakibi wakibi Awaiting requested review from wakibi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThatcherK @akmiller01