Do not set ignoreFailures on tests, fixes deephaven#572 (deephaven#588)

devinrsmith · May 14, 2021 · 493114d · 493114d
1 parent 199aebd
commit 493114d
Show file tree

Hide file tree

Showing 8 changed files with 4 additions and 26 deletions.
diff --git a/.github/scripts/fail-on-xml-failures.sh b/.github/scripts/fail-on-xml-failures.sh
diff --git a/.github/workflows/check-ci.yml b/.github/workflows/check-ci.yml
@@ -32,13 +32,9 @@ jobs:
         with:
           job-id: checks
           # todo: eventually expand to more
-          arguments: --scan quick
+          arguments: --scan --continue quick
           gradle-version: wrapper
 
-      - name: Check for xml failures
-        run: |
-          ./.github/scripts/fail-on-xml-failures.sh
-        
       - name: Upload Test Results
         uses: actions/upload-artifact@v2
         if: always()

diff --git a/.github/workflows/long-check-ci.yml b/.github/workflows/long-check-ci.yml
@@ -34,10 +34,6 @@ jobs:
           arguments: --scan --continue check
           gradle-version: wrapper
 
-      - name: Check for xml failures
-        run: |
-          ./.github/scripts/fail-on-xml-failures.sh
-
       - name: Upload Test Results
         uses: actions/upload-artifact@v2
         if: always()

diff --git a/Configuration/build.gradle b/Configuration/build.gradle
@@ -25,7 +25,6 @@ test {
     useJUnit()
 
     workingDir = "$rootDir"
-    ignoreFailures = true
     enableAssertions = true
     maxHeapSize = '3g'
 

diff --git a/Net/build.gradle b/Net/build.gradle
@@ -12,7 +12,6 @@ test {
     useJUnit()
 
     workingDir = "$rootDir"
-    ignoreFailures = true
     enableAssertions = true
     maxHeapSize = '3g'
 

diff --git a/Stats/build.gradle b/Stats/build.gradle
@@ -13,7 +13,6 @@ test {
     useJUnit()
 
     workingDir = "$rootDir"
-    ignoreFailures = true
     enableAssertions = true
     maxHeapSize = '3g'
 

diff --git a/build.gradle b/build.gradle
@@ -184,7 +184,6 @@ configure modsRegular,
         new File("$rootDir/tmp/workspace".toString()).mkdirs()
         new File("$rootDir/tmp/logs".toString()).mkdirs()
 
-        // TODO fix / move flaky tests so we can make ignoreFailures false again
         ignoreFailures = TestTools.allowFailure project
         if (ignoreFailures) {
             // begin dirty trick to ensure you can re-run failed tests.

diff --git a/buildSrc/src/main/groovy/TestTools.groovy b/buildSrc/src/main/groovy/TestTools.groovy
@@ -157,7 +157,9 @@ By default only runs in CI; to run locally:
         return !('test' in (p.gradle.startParameter.excludedTaskNames))
     }
 
+    // TODO (core#598): Remove allowFailure logic
+    @Deprecated
     static boolean allowFailure(Project project) {
-        return project.findProperty('allowFailure') != 'false'
+        return project.findProperty('allowFailure') == 'true'
     }
 }