Fix: never decode integers as Decimals
#224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unnecessary to decode them as `Decimal`s with `decimal: true`,
since integers can already be of arbitrary size, limited only by memory.
It can create issues in controllers when the `Plug.Parsers` plug
is configured to use Poison with the `:decimal` option:
```elixir
plug Plug.Parsers,
parsers: [:urlencoded, :multipart, :json],
pass: ["*/*"],
json_decoder: {Poison, :decode!, [[decimal: true]]}
```
|
Hi, Devin! I hope you're doing well! Is there a chance to get this merged or at least reviewed? I think it's important and it shouldn't sit around any longer. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unnecessary to decode them as
Decimals withdecimal: true, since integers can already be of arbitrary size, limited only by memory.It can create issues in controllers when the
Plug.Parsersplug is configured to use Poison with the:decimaloption: