Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add i18n hydration #1

Closed
wants to merge 1 commit into from
Closed

fix(core): add i18n hydration #1

wants to merge 1 commit into from

Conversation

devknoll
Copy link
Owner

@devknoll devknoll commented Feb 2, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@devknoll devknoll force-pushed the x-i18n-hydration branch 4 times, most recently from 8d2065a to 84c2733 Compare February 16, 2024 21:08
devknoll pushed a commit that referenced this pull request May 23, 2024
…lar#55747)

The first test asserts that bubbling does not work right now.

The second asserts that stopPropagation works, which should pass when test #1 passes too.

The third test asserts properties about the events passed to the event handler.

THe fourth test asserts that mouse events do not translate to jsaction nor help emit the jsaction binary. This required a change in code to make this pass.

PR Close angular#55747
@devknoll devknoll closed this May 23, 2024
@devknoll devknoll deleted the x-i18n-hydration branch May 23, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant