Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell Constructors #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Spell Constructors #12

wants to merge 3 commits into from

Conversation

tokumori
Copy link

No description provided.

/**
* Returns a string of all of the spell's details.
* The format doesn't matter, as long as it contains the spell name, cost, and description.
*
* @name getDetails
* @return {string} details containing all of the spells information.
*/

this.getDetails = function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you are adding these to the Spell.prototype instead of as instance methods.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I did after I committed because I started noticing places I wanted to use prototype instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants