Apply migration to Swift 4

[damien-rivet]

Implements #158.

Changelog

Added Swift version file.
Moved Swift version to Project instead of Targets.
Updated dependencies.
Fixed SwiftLint errors.
Splitted Router tests between multiple files.
Renamed some variables in tests.

[devluckybot]

	1 Warning
⚠️	Big PR

Generated by 🚫 Danger

[damien-rivet]

Sorry for the multiple commits, I didn't expect Travis to complain that much...

[codecov-io]

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          10       10           
  Lines         481      481           
=======================================
  Hits          479      479           
  Misses          2        2

[damien-rivet]

Hi @MP0w,

Will you be able to review my PR at some point?

Thanks in advance for your answer.

[MP0w]

Ty for the PR, I see you moved around some specs and eventually added some. Could you separate it from the swift 4 PR (opening another PR) and explain the reason? Thanks

[MP0w]

Aren't these specs already covered in the Router specs?

[damien-rivet]

They were, I haven't added new specs, I just splat the existing one into multiple files to simplify the reading and to prevent SwiftLint from failing the build.

But if you prefer this to come from another PR, I think I should be able to make it happen.

[joanromano]

Hey @Ethenyl @MP0w sorry didn't get to this in time - I believe we should still attempt to merge it; can I help? Do you want me to review it?

[damien-rivet]

Hi @joanromano,

It's been a while since I gave a look to this PR... If you want you can review it, I'll also try to upgrade to Swift 4.1 (if possible without breaking the CI) when I have some time.

[joanromano]

Hi @Ethenyl I have checked the PR and I have some questions:

• Some of the specs have some no-op changes (e.g from Dog to Labrador) - I don't think this applies to a Swift 4 migration PR
• Some specs are moved and the organization of the specs, in general, is changed - again, I don't think this applies to a Swift 4 migration PR and I'd be happy to discuss it in another PR

Other than that I am happy to review and merge only changes corresponding to a Swift 4 migration.