Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/liquibase configuration #340
base: master
Are you sure you want to change the base?
Feature/liquibase configuration #340
Changes from 20 commits
0bc6d9f
2f66b73
31b8375
50ec86c
899e978
7023dc6
27adf36
805b5ea
2005578
94b38ab
c2ba0aa
1c9b7f8
2a797ae
af85a10
96ce077
32ba73d
b461dfb
2f14c02
13de274
8f704fd
42ad82e
db79005
163ebe9
cae564a
e49273e
6e2eb69
b2f1dd8
ee7f6a5
d2d0e0e
80641d8
7610cb1
cd8291b
a6d3fea
47ef2ec
5afd20a
ea8dd24
9e0f3fa
a46fad1
77f0161
49a7d71
50c91ae
8233899
3b9d0ea
9a4b7a1
c17e4f3
89c23b8
4042d7a
246a4d7
8bfb77f
2f6f5fe
7014b49
679b970
f850517
6c39c54
3d50fe3
9ba5ef5
4540198
b29c704
dc54073
dabd4c8
bab5a5f
e00c2e7
5ef5923
ee9318b
06ea818
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never use
printStackTrace()
in productive code. IMHO better than logging is to rethrow as runtime exception and let the test fail instead of silently ignoring a severe error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change it to rethrow this exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what has been changed here?
The diff shows every line has changed. EOL stlye changed between unix and linux?
The only content change I can see here is that you added
standalone="no"
. What was the reason for that change? I can not see any...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here? No change at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will review it again and restore the file if changes not required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the commented code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again the diff is not readable. IMHO you have a general problem with your setup of git and are changing all EOLs accidentally. Can you please change and fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix this setup issue and will make it work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indendation with velocity is tricky: every whitespace will be written to the output. That is " " before the
#if
as well as " " before@Inject
resulting in 6 spaces before annotation and 4 spaces before private field whereas we should only have two spaces each.BTW: I am wondering why we do not use the
TestCleanerPlugin
in this test to abstract from liquibase of flyway instead...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see
TestCleanerPluginLiquibase
. IMHO we can avoid all this redundancy and velocity macro complexity by injecting and usingTestCleanerPlugin
.