Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[global] add social badges to shortcodes #14902

Merged
merged 10 commits into from
Feb 22, 2025

Conversation

themightymuppet
Copy link
Contributor

  • adds the following social icons as shortcodes to be used on any page:
    • Linkedin
    • Twitter
    • Listserv subscription link
    • slack invitation link
    • mastadon
    • bluesky
    • Youtube
  • updates new event template to include social shortcodes

@themightymuppet themightymuppet requested review from a team as code owners February 20, 2025 19:35
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for devopsdays-web ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fa492e8
🔍 Latest deploy log https://app.netlify.com/sites/devopsdays-web/deploys/67b937f9a4aaf800081dfdfa
😎 Deploy Preview https://deploy-preview-14902--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@themightymuppet
Copy link
Contributor Author

themightymuppet commented Feb 20, 2025

failed jobs are unrelated to changes The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings

I tested this locally using a Denver 2025 event with all new shortcodes enabled and had no issues.

Screenshot 2025-02-20 at 12 35 05

Screenshot 2025-02-20 at 12 52 14

Copy link
Member

@mattstratton mattstratton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks cool! I'm not quite sure if we have a good preview - it says to look at Denver but I don't see changes to Denver in this PR.

Also can you add the new fields to themes/devopsdays-theme/reference.md as well?

@mattstratton
Copy link
Member

This looks cool! I'm not quite sure if we have a good preview - it says to look at Denver but I don't see changes to Denver in this PR.

Oh you did the screenshot. That's fine! If we can just add the documentation I mentioned this should be good to go!

@mattstratton
Copy link
Member

I wouldn't block this PR on it, but we could do an enhancement after this is merged where we move the CSS that you have is in line into the main style sheets, but that's not critical at the moment

@themightymuppet
Copy link
Contributor Author

I wouldn't block this PR on it, but we could do an enhancement after this is merged where we move the CSS that you have is in line into the main style sheets, but that's not critical at the moment

Thanks @mattstratton ! Since i was in updating the reference anyway (thanks forgot about that file!) i went ahead and moved the css too. Ready to re-review, danke!

@mattstratton
Copy link
Member

Actually the CSS files get generated by the SCSS files so changing the .css file will get overwritten if we re-run the gulp tasks. I can fix this though and move it to the SCSS in another PR!

@mattstratton mattstratton merged commit 6e8a990 into devopsdays:main Feb 22, 2025
8 checks passed
themightymuppet added a commit to DevOpsDays-Denver/devopsdays-web that referenced this pull request Feb 22, 2025
@themightymuppet
Copy link
Contributor Author

doh, thanks @mattstratton ! Something I'd probably have picked up had i ever made it to one of the working group syncs 😅 Much appreciated 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants