-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[global] add social badges to shortcodes #14902
[global] add social badges to shortcodes #14902
Conversation
themightymuppet
commented
Feb 20, 2025
- adds the following social icons as shortcodes to be used on any page:
- Listserv subscription link
- slack invitation link
- mastadon
- bluesky
- Youtube
- updates new event template to include social shortcodes
✅ Deploy Preview for devopsdays-web ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
failed jobs are unrelated to changes I tested this locally using a Denver 2025 event with all new shortcodes enabled and had no issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks cool! I'm not quite sure if we have a good preview - it says to look at Denver but I don't see changes to Denver in this PR.
Also can you add the new fields to themes/devopsdays-theme/reference.md as well?
Oh you did the screenshot. That's fine! If we can just add the documentation I mentioned this should be good to go! |
I wouldn't block this PR on it, but we could do an enhancement after this is merged where we move the CSS that you have is in line into the main style sheets, but that's not critical at the moment |
Thanks @mattstratton ! Since i was in updating the reference anyway (thanks forgot about that file!) i went ahead and moved the css too. Ready to re-review, danke! |
Actually the CSS files get generated by the SCSS files so changing the .css file will get overwritten if we re-run the gulp tasks. I can fix this though and move it to the SCSS in another PR! |
doh, thanks @mattstratton ! Something I'd probably have picked up had i ever made it to one of the working group syncs 😅 Much appreciated 🙏🏽 |