Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating users, use 'preferred_username' if 'user_name' can't be found #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avanvucht
Copy link

OpenID Connect specs say the username is 'preferred_username' not 'user_name' so let's go with the latter if we can't find 'user_name'.

This solves an issue where I was getting an error "Unable to create user due to Login cannot be blank" in my Redmine 3.4.3 with no LDAP connection.

…er_name' so let's go with the latter if we can't find 'user_name'
@jcmcken
Copy link
Contributor

jcmcken commented Feb 9, 2018

Related to #11. Some providers use nickname but not preferred_username. Maybe a chain of claims needs to be tried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants