Issue 243 : [REFACTORING] Make ChatResponsePanel more modular #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! The more smaller/manageable classes we have, the better. #Thanks |
|
Just noticed that the output panel now has some sort of top padding and some strange cut-off in the footer. Top of panel Bottom panel cut-off |
|
Hello @stephanj will check and fix this ASAP |
|
Hello @stephanj i did create a new PR including a set composed of 2 commit waves (one for the rollback + one for the fixed UI code with the expected modularity), normally it should be ok. Please let me know if it's ok for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @stephanj Trying to go on this issue 243
Creation of distinctive panels objects for elements structuring ChatResponsePanel, we have a chatresponsePanel sub package (i dont know if this is a great idea at all but the number of panels class is starting to be consequent), so we have:
Let me know if this is not good